-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WORKSPACE #3368
base: main
Are you sure you want to change the base?
Update WORKSPACE #3368
Conversation
Document the manual build of CDI builder helper container and typical make targets Signed-off-by: cfillekes <[email protected]>
Delete one of the two identical lines. Signed-off-by: Gxliu <[email protected]>
Hi @kpol-lgx. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Create build-the-builder.md
change the option of BUILD_ARCH. cover arm64 with aarch64. Signed-off-by: Gxliu <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
It will get squashed into a single commit before merging. |
Hmm look at the diff, it looks like unrelated changes and commits got pulled into this PR |
I see the WORKSPACE and the documentation changes. Are you seeing something else? |
So you want just the WORKSPACE and not the documentation change? |
Yes, I doubt the author wants to pull someone elses commit as well |
@kpol-lgx: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Delete one of the two identical lines.
What this PR does / why we need it:
At the beginning of
WORKSPACE
, the parameters of the twoload
functions are exactly the same. So maybe one of them should be removed.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: