-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Try tackle log flakes by delaying log rotation #3024
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex Kalenyuk <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-containerized-data-importer-e2e-hpp-previous |
11 similar comments
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
/test pull-containerized-data-importer-e2e-hpp-previous |
@brianmcarey @xpivarc ever had this kind of problem in kubevirt/kubevirt? where logs "disappear" from debugging manifest |
I do not think so. |
fyi @tiraboschi |
The speed of the serial console is capped at 115200 bps, so in order to generate 20MiB we need to flood the serial console for 1456 seconds (24 minutes). |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@kubevirt-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@akalenyu: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rotten issues close after 30d of inactivity. /close |
@kubevirt-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@akalenyu: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Ultimately we probably want to shift away from tests that depend on logs
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: