Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Try tackle log flakes by delaying log rotation #3024

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Try tackle log flakes by delaying log rotation #3024

wants to merge 1 commit into from

Conversation

akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented Dec 4, 2023 •
edited
Loading

What this PR does / why we need it:
Ultimately we probably want to shift away from tests that depend on logs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 4, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akalenyu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 4, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

11 similar comments
@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 4, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 4, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 5, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 5, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 5, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 6, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 6, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 6, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

akalenyu commented Dec 7, 2023

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

/test pull-containerized-data-importer-e2e-hpp-previous

@akalenyu
Copy link
Collaborator Author

@brianmcarey @xpivarc ever had this kind of problem in kubevirt/kubevirt? where logs "disappear" from debugging manifest

@xpivarc
Copy link
Member

xpivarc commented Dec 18, 2023

@brianmcarey @xpivarc ever had this kind of problem in kubevirt/kubevirt? where logs "disappear" from debugging manifest

I do not think so.

@akalenyu akalenyu mentioned this pull request Jan 14, 2024
Merged
@akalenyu
Copy link
Collaborator Author

fyi @tiraboschi

@tiraboschi
Copy link
Member

fyi @tiraboschi

The speed of the serial console is capped at 115200 bps, so in order to generate 20MiB we need to flood the serial console for 1456 seconds (24 minutes).
I think we can definitively exclude we are reaching this limit for the guest console logs during our tests.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2024
@kubevirt-bot kubevirt-bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 18, 2024
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu akalenyu mentioned this pull request Jul 31, 2024
Merged
@akalenyu
Copy link
Collaborator Author

/reopen

@kubevirt-bot kubevirt-bot reopened this Jul 31, 2024
@kubevirt-bot
Copy link
Contributor

@akalenyu: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu
Copy link
Collaborator Author

/reopen
/remove-lifecycle rotten

@kubevirt-bot kubevirt-bot reopened this Aug 31, 2024
@kubevirt-bot
Copy link
Contributor

@akalenyu: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya-r maya-r Awaiting requested review from maya-r

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akalenyu @kubevirt-bot @xpivarc @tiraboschi