Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix suspend judgement #196

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix: fix suspend judgement #196

merged 1 commit into from
Sep 24, 2024

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Sep 24, 2024

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@FogDong FogDong changed the title fix: fix suspend judgement Fix: fix suspend judgement Sep 24, 2024
@FogDong FogDong force-pushed the fix-suspend branch 3 times, most recently from 952ac74 to 7a35335 Compare September 24, 2024 15:16
fix: fix context in provider

Signed-off-by: FogDong <[email protected]>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.67%. Comparing base (c3331e7) to head (e88ffaa).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/executor/workflow.go 66.66% 1 Missing and 1 partial ⚠️
pkg/providers/http/http.go 0.00% 1 Missing and 1 partial ⚠️
pkg/providers/legacy/http/http.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   63.44%   62.67%   -0.77%     
==========================================
  Files          51       62      +11     
  Lines        4604     4410     -194     
==========================================
- Hits         2921     2764     -157     
- Misses       1282     1315      +33     
+ Partials      401      331      -70     
Flag Coverage Δ
unit-test 62.67% <45.45%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FogDong FogDong merged commit 55f1433 into kubevela:main Sep 24, 2024
15 of 17 checks passed
Copy link

Backport failed for release-0.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.5
git worktree add -d .worktree/backport-196-to-release-0.5 origin/release-0.5
cd .worktree/backport-196-to-release-0.5
git checkout -b backport-196-to-release-0.5
ancref=$(git merge-base 76db4ac03eaa852b97da3d0d32c39ae8eb06ddcb e88ffaaa7adb9eebd2e615e68e0b8bc13258db78)
git cherry-pick -x $ancref..e88ffaaa7adb9eebd2e615e68e0b8bc13258db78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant