Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix context in provider #194

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix: fix context in provider #194

merged 1 commit into from
Aug 16, 2024

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Aug 16, 2024

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@FogDong FogDong changed the title fix: fix context in provider Fix: fix context in provider Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.63%. Comparing base (c3331e7) to head (b7ead10).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/providers/http/http.go 0.00% 1 Missing and 1 partial ⚠️
pkg/providers/legacy/http/http.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   63.44%   62.63%   -0.82%     
==========================================
  Files          51       62      +11     
  Lines        4604     4410     -194     
==========================================
- Hits         2921     2762     -159     
- Misses       1282     1317      +35     
+ Partials      401      331      -70     
Flag Coverage Δ
unit-test 62.63% <0.00%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FogDong FogDong merged commit 76db4ac into kubevela:main Aug 16, 2024
14 of 18 checks passed
FogDong added a commit to FogDong/workflow that referenced this pull request Sep 24, 2024
fix: fix context in provider

Signed-off-by: FogDong <[email protected]>
FogDong added a commit to FogDong/workflow that referenced this pull request Sep 24, 2024
fix: fix context in provider

Signed-off-by: FogDong <[email protected]>
FogDong added a commit to FogDong/workflow that referenced this pull request Sep 24, 2024
fix: fix context in provider

Signed-off-by: FogDong <[email protected]>
FogDong added a commit that referenced this pull request Sep 24, 2024
Fix: fix context in provider (#194)

fix: fix context in provider

Signed-off-by: FogDong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant