-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: refactor the cue engine with cuex #162
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 63.44% 67.78% +4.33%
==========================================
Files 51 55 +4
Lines 4604 3858 -746
==========================================
- Hits 2921 2615 -306
+ Misses 1282 952 -330
+ Partials 401 291 -110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
63f9400
to
52a8c9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Generally LGTM. Let's make a sync PR in the kubevela/kubevela and see if it works.
ceecc23
to
4b83190
Compare
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Signed-off-by: FogDong <[email protected]>
Description of your changes
Chore: refactor the cue engine with cuex
TODO:
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer