Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor the cue engine with cuex #162

Merged
merged 17 commits into from
Jul 27, 2024
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 24, 2023

Description of your changes

Chore: refactor the cue engine with cuex

TODO:

  • refactor config provider and add it to cuex.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Attention: Patch coverage is 71.34220% with 237 lines in your changes missing coverage. Please review.

Project coverage is 67.78%. Comparing base (c3331e7) to head (ce912dc).

Files Patch % Lines
pkg/providers/legacy/metrics/prom_check.go 38.04% 51 Missing and 6 partials ⚠️
pkg/providers/legacy/kube/kube.go 62.23% 32 Missing and 22 partials ⚠️
pkg/cue/model/value/value.go 53.65% 17 Missing and 2 partials ⚠️
pkg/providers/legacy/http/http.go 79.12% 10 Missing and 9 partials ⚠️
pkg/tasks/custom/action.go 70.31% 18 Missing and 1 partial ⚠️
pkg/providers/legacy/workspace/workspace.go 74.64% 10 Missing and 8 partials ⚠️
pkg/providers/legacy/util/util.go 76.66% 7 Missing and 7 partials ⚠️
pkg/context/context.go 65.21% 3 Missing and 5 partials ⚠️
pkg/executor/workflow.go 60.00% 3 Missing and 3 partials ⚠️
pkg/providers/types/types.go 81.25% 4 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   63.44%   67.78%   +4.33%     
==========================================
  Files          51       55       +4     
  Lines        4604     3858     -746     
==========================================
- Hits         2921     2615     -306     
+ Misses       1282      952     -330     
+ Partials      401      291     -110     
Flag Coverage Δ
e2etests 21.80% <19.58%> (?)
unit-test 62.83% <64.57%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

controllers/testdata/test-apply.yaml Show resolved Hide resolved
pkg/executor/workflow.go Outdated Show resolved Hide resolved
pkg/generator/generator.go Outdated Show resolved Hide resolved
@FogDong FogDong force-pushed the feat-cuex branch 2 times, most recently from 63f9400 to 52a8c9a Compare April 25, 2023 03:47
Copy link
Contributor

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Generally LGTM. Let's make a sync PR in the kubevela/kubevela and see if it works.

FogDong and others added 8 commits July 13, 2024 16:41
@FogDong FogDong merged commit 7d94489 into kubevela:main Jul 27, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants