[Backport release-0.4] Fix: fix panic when workflow is skipped (#123)

Fix: fix panic when workflow is skipped Signed-off-by: FogDong <[email protected]> (cherry picked from commit b3beb58) Co-authored-by: FogDong <[email protected]>
kubevela · Jan 30, 2023 · d4644ef · d4644ef
1 parent e171ba4
commit d4644ef
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/pkg/executor/workflow.go b/pkg/executor/workflow.go
@@ -122,20 +122,20 @@ func (w *workflowExecutor) ExecuteRunners(ctx monitorContext.Context, taskRunner
 		return v1alpha1.WorkflowStateSucceeded, nil
 	}
 
-	if cacheValue, ok := StepStatusCache.Load(cacheKey); ok {
-		// handle cache resource
-		if len(status.Steps) < cacheValue.(int) {
-			return v1alpha1.WorkflowStateSkipped, nil
-		}
-	}
-
 	wfCtx, err := w.makeContext(ctx, w.instance.Name)
 	if err != nil {
 		ctx.Error(err, "make context")
 		return v1alpha1.WorkflowStateExecuting, err
 	}
 	w.wfCtx = wfCtx
 
+	if cacheValue, ok := StepStatusCache.Load(cacheKey); ok {
+		// handle cache resource
+		if len(status.Steps) < cacheValue.(int) {
+			return v1alpha1.WorkflowStateSkipped, nil
+		}
+	}
+
 	e := newEngine(ctx, wfCtx, w, status, taskRunners)
 
 	err = e.Run(ctx, taskRunners, dagMode)