Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(addons): Align Button with Title in AddonDetailDialog #915

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

am6737
Copy link
Contributor

@am6737 am6737 commented Oct 5, 2024

Description of your changes

Fixes #914

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.02%. Comparing base (2ab672c) to head (76f1131).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2ab672c) and HEAD (76f1131). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2ab672c) HEAD (76f1131)
apiserver-unittests 1 0
server-e2e-tests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   59.01%   51.02%   -8.00%     
==========================================
  Files         116      116              
  Lines       19846    16511    -3335     
==========================================
- Hits        11713     8424    -3289     
- Misses       6696     6842     +146     
+ Partials     1437     1245     -192     
Flag Coverage Δ
apiserver-unittests ?
server-e2e-tests 51.02% <ø> (+2.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit 8e11f93 into kubevela:main Oct 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button alignment issue in AddonDetailDialog
2 participants