Fix: Set default values for traits in VelaUX #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addressed the issue where default values for traits (including "cpuscaler", "hpa", "resource", "k8s-update-strategy") were not being set properly. Signed-off-by: am6737 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #650
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer
Traits with default values, such as "cpuscaler," "hpa," "resource," and "k8s-update-strategy," require some input to trigger the onChange event before the properties can be set correctly. To address this, I called onChange during the initialization phase to ensure the default values are set properly.
I realize that this approach may not be the most elegant solution, so I'm open to any suggestions for a better implementation or alternative ways to handle default values more effectively.