Fix: Prevent crashes when accessing cluster details #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
approved these changes
Oct 8, 2024
barnettZQG
reviewed
Oct 9, 2024
| onClose = () => { | ||
| this.props.onClose(); | ||
| this.resetField(); | ||
| }; | ||
|
|
||
| onOk = () => { | ||
| const { editMode, cluster } = this.state; | ||
| const { editClusterName } = this.props; |
There was a problem hiding this comment.
What's the need for this code change?
There was a problem hiding this comment.
What's the need for this code change?
Thank you for pointing this out! I'll go ahead and remove it to clean up the code.
- Added optional chaining to safely access cluster details in `AddClusterDialog`. This fix addresses the issue where the page crashes when trying to load details for an inaccessible cluster. Signed-off-by: am6737 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
- Coverage 59.01% 51.06% -7.96%
==========================================
Files 116 116
Lines 19846 16511 -3335
==========================================
- Hits 11713 8431 -3282
- Misses 6696 6835 +139
+ Partials 1437 1245 -192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddClusterDialog.This fix addresses the issue where the page crashes when trying to load details for an inaccessible cluster.
Description of your changes
Fixes #685
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer