-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add non-page plugin positions #839
Open
chivalryq
wants to merge
1
commit into
kubevela:main
Choose a base branch
from
chivalryq:feat/non-page-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { join } from "lodash"; | ||
|
||
export type Marker = string; | ||
export type Position = string | ||
|
||
export const Sep = '.' | ||
// j accept random number of Maker | ||
const j = (...s: Marker[]): Position => join(s, Sep) as Position; | ||
|
||
export const MDefinition: Marker = 'definition'; | ||
|
||
export const MComponent: Marker = 'component'; | ||
export const MTrait: Marker = 'trait'; | ||
export const MPolicy: Marker = 'policy'; | ||
export const MWorkflowStep: Marker = 'workflow_step'; | ||
|
||
export const PComponent: Position = j(MDefinition, MComponent); | ||
export const PTrait: Position = j(MDefinition, MTrait); | ||
export const PPolicy: Position = j(MDefinition, MPolicy); | ||
export const PWorkflowStep: Position = j(MDefinition, MWorkflowStep); | ||
|
||
// checkPrefix checks if the given position is a prefix of the given position. | ||
function checkPrefix(position: Position, prefix: string): [boolean, string] { | ||
let ok = position.startsWith(prefix); | ||
if (!ok) { | ||
return [false, ""]; | ||
} | ||
let name = position.slice(prefix.length + 1); | ||
return [true, name]; | ||
} | ||
|
||
// isComponent checks if a position is a component. return [true, name] if it is. | ||
export function isComponent(p: Position): [boolean, string] { | ||
return checkPrefix(p, PComponent); | ||
} | ||
|
||
// isTrait checks if a position is a trait. return [true, name] if it is. | ||
export function isTrait(p: Position): [boolean, string] { | ||
return checkPrefix(p, PTrait); | ||
} | ||
|
||
// isPolicy checks if a position is a policy. return [true, name] if it is. | ||
export function isPolicy(p: Position): [boolean, string] { | ||
return checkPrefix(p, PPolicy); | ||
} | ||
|
||
// isWorkflowStep checks if a position is a workflow step. return [true, name] if it is. | ||
export function isWorkflowStep(p: Position): [boolean, string] { | ||
return checkPrefix(p, PWorkflowStep); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / CodeQL
Semicolon insertion