Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add codeowner in release 1.8 #822

Open
wants to merge 4 commits into
base: release-1.8
Choose a base branch
from

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented May 18, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <[email protected]>
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -27.54 ⚠️

Comparison is base (d3710a6) 61.27% compared to head (7e393f6) 33.74%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.8     #822       +/-   ##
================================================
- Coverage        61.27%   33.74%   -27.54%     
================================================
  Files              109       89       -20     
  Lines            19126    17667     -1459     
================================================
- Hits             11719     5961     -5758     
- Misses            5967    10811     +4844     
+ Partials          1440      895      -545     
Flag Coverage Δ
apiserver-unittests 33.74% <ø> (-0.03%) ⬇️
server-e2e-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 94 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

chivalryq added 3 commits May 18, 2023 11:26
Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants