Fix: fix the log for log data #754
Conversation
Signed-off-by: FogDong <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 60.97% 61.04% +0.06%
==========================================
Files 106 106
Lines 18869 18881 +12
==========================================
+ Hits 11505 11525 +20
+ Misses 5944 5937 -7
+ Partials 1420 1419 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -684,6 +700,10 @@ func getResourceLogs(ctx context.Context, config *rest.Config, cli client.Client | |||
| } | |||
| } | |||
| if shouldPrint { | |||
| match := re.FindStringSubmatch(s) | |||
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
The log data is formatted to string in the controller, with some suffix like stepSessionID=id, Name=name, the regex fill out the suffix and remain the data that users care about.
Description of your changes
Fixes #
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer