Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the log for log data #754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 12, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.06 🎉

Comparison is base (dc7a9ce) 60.97% compared to head (17efb87) 61.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   60.97%   61.04%   +0.06%     
==========================================
  Files         106      106              
  Lines       18869    18881      +12     
==========================================
+ Hits        11505    11525      +20     
+ Misses       5944     5937       -7     
+ Partials     1420     1419       -1     
Flag Coverage Δ
apiserver-unittests 33.70% <0.00%> (-0.02%) ⬇️
server-e2e-tests 49.91% <78.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/domain/service/pipeline.go 70.40% <78.57%> (+0.05%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -684,6 +700,10 @@ func getResourceLogs(ctx context.Context, config *rest.Config, cli client.Client
}
}
if shouldPrint {
match := re.FindStringSubmatch(s)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?

Copy link
Member Author

@FogDong FogDong Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log data is formatted to string in the controller, with some suffix like stepSessionID=id, Name=name, the regex fill out the suffix and remain the data that users care about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants