Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started doc updated #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Madhur97
Copy link

Added documentation for missing namespaces and fixed indentation.

@ghost
Copy link

ghost commented Aug 24, 2021

CLA assistant check
All CLA requirements met.

@Madhur97
Copy link
Author

/assign @zzxwill

```shell
$ helm install -n tf-controller terraform-controller terraform-controller-0.1.8.tgz
$ helm install terraform-controller terraform-controller-0.1.8.tgz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will helm install --create-namespace -n tf-controller help?

@@ -234,13 +235,21 @@ If you'd like to use AWS session token for temporary credentials, please export
$ export AWS_SESSION_TOKEN=zzz
```

Create a namespace named `vela-system` if doesn't exist
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create the namespace at the very beginning?

@zzxwill
Copy link
Collaborator

zzxwill commented Sep 8, 2021

@Madhur97 Can you continue with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants