Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: replace deprecated command with environment file #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jongwooo
Copy link

@jongwooo jongwooo commented Dec 16, 2023

Description

Closes #44

Update .github/workflows/chart.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=TAG::${GITHUB_REF#refs/tags/}

TO-BE

echo "TAG::${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT

@jongwooo jongwooo requested a review from Somefive as a code owner December 16, 2023 17:58
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ecdbb4) 83.74% compared to head (4dd42b7) 83.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files          36       36           
  Lines        1095     1095           
=======================================
  Hits          917      917           
  Misses        116      116           
  Partials       62       62           
Flag Coverage Δ
unit-test 83.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
1 participant