Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikhil/linkfix #1266

Closed

Conversation

nikhilchauhangithub
Copy link
Contributor

Description of your changes

fix the standalone and Kubernetes hyperlink on the page https://kubevela.io/docs/install
"Fixes #6238":

I have:

  • [ x] Read and followed KubeVela's contribution process.
  • [x ] Update sidebar.js if adding a new page.
  • [x ] Run yarn start to ensure the changes has taken effect.

-->

Signed-off-by: nikhilchauhangithub <[email protected]>
Signed-off-by: nikhilchauhangithub <[email protected]>
@wonderflow
Copy link
Contributor

Hi @Arhell , do you know how to reduce the changes in yarn.lock?

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not need to update dependencies, there is another one for this #1261

I personally use this https://www.npmjs.com/package/npm-check-updates

@chivalryq
Copy link
Member

Both links here works well in Edge:

image

And I tried several times, found if I open https://kubevela.io/docs/install/ directly and the link is broken. However, if I go to this page by

  1. Open https://kubevela.io/docs/
  2. Click Installation

Then it works well. Do you have any ideas about this @Arhell? Before it is clear we should pend this PR.

@chivalryq
Copy link
Member

Related: #1268 Closing this PR because this is not the root problem.

@chivalryq chivalryq closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants