[Addon] Fix for datadog trait logging source setup #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kolossi
requested review from
wangyikewxgm,
wonderflow,
barnettZQG,
FogDong,
anoop2811 and
dhiguero
as code owners
…iffers from component name Signed-off-by: kolossi <[email protected]>
FogDong
reviewed
Sep 6, 2024
FogDong
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when serviceName differs from component name
Description of your changes
This fixes the logging annotation added by this trait so that it uses the component name
and not any serviceName alias specified. This is to give correct operation of the
logging source functionality.
How has this code been tested?
Used on own cluster
Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
(N/A - this addon to remain alpha)