Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] fix: removing hardcoded non-existing flink operator helm chart, and allowing for parameterising operator version #760

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

kujon
Copy link
Contributor

@kujon kujon commented Jul 17, 2024

Hello Everyone 👋 Flink people seem to have removed old versions of the operator from their helm chart repository. The oldest version that is still in existence is 1.7.0. I've removed the hardcoded version reference, and allowed for parameterising the version going forward.

Description of your changes

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

…llowing for parameterising operator version

Signed-off-by: Jakub Korzeniowski <[email protected]>
@wonderflow wonderflow merged commit 9364a49 into kubevela:master Jul 17, 2024
3 checks passed
@kujon kujon deleted the fixing_flink branch July 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants