Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] velaux allow a custom ingress class name #741

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
2 changes: 1 addition & 1 deletion addons/velaux/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: velaux
version: v1.9.3
version: v1.9.4
description: KubeVela User Experience (UX). An extensible, application-oriented delivery and management Platform.
icon: https://static.kubevela.net/images/logos/KubeVela%20-03.png
url: https://kubevela.io
Expand Down
2 changes: 1 addition & 1 deletion addons/velaux/parameter.cue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ parameter: {
// +usage=Specify the name of the certificate cecret, if set, means enable the HTTPs.
secretName?: string
// +usage=Specify the gateway type.
gatewayDriver: *"nginx" | "traefik"
gatewayDriver: *"nginx" | "traefik" | _
// +usage=Specify the serviceAccountName for apiserver
serviceAccountName: *"kubevela-ux" | string
// +usage=Specify the service type.
Expand Down
4 changes: 2 additions & 2 deletions addons/velaux/resources/server.cue
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ enableImpersonation: *[ if parameter["enableImpersonation"] {
}] | []

_nginxTrait: *[
if parameter["domain"] != _|_ && parameter["gatewayDriver"] == "nginx" {
if parameter["domain"] != _|_ && parameter["gatewayDriver"] != "traefik" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why != traefik go the logic?

{
type: "gateway"
properties: {
domain: parameter["domain"]
http: {
"/": 8000
}
class: "nginx"
class: parameter["gatewayDriver"]
}
}
},
Expand Down
Loading