Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres operator #678

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

MdSahil-oss
Copy link
Contributor

@MdSahil-oss MdSahil-oss commented Apr 19, 2023

Description of your changes

Update Postgres Addon.

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <[email protected]>
@MdSahil-oss
Copy link
Contributor Author

@wonderflow I've updated postgres addon, I hope now you will be able to run Bytebase with postgres addon :)

Signed-off-by: MdSahil-oss <[email protected]>
@@ -0,0 +1,37 @@
"postgres-expose": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we reuse the expose trait?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonderflow I've updated postgres-expose trait as expose trait. Please reivew it again.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to create a new one instead of using expose trait?

Signed-off-by: MdSahil-oss <[email protected]>
wonderflow
wonderflow previously approved these changes Apr 21, 2023
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

Comment on lines +14 to +23
apiVersion: "v1"
kind: "Service"
metadata: annotations: parameter.annotations
spec: {
selector: {
"application": "spilo"
"cluster-name": "postgres"
"spilo-role": "master"
"team": "acid"
}
Copy link
Collaborator

@wangyikewxgm wangyikewxgm May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same concern with @wonderflow . It seems that the existing Expose trait can accomplish the same functionality. Have you considered using it instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyikewxgm @wonderflow I tried to do so, But I'm getting an error

could not create cluster: could not create master endpoint: endpoints "postgres" already exists

it seems like expose trait is getting created first then postgres cluster using built in expose trait.

@MdSahil-oss
Copy link
Contributor Author

MdSahil-oss commented May 12, 2023

@wangyikewxgm @wonderflow I tried to do so, But I'm getting an error

could not create cluster: could not create master endpoint: endpoints "postgres" already exists

it seems like expose trait is getting created first then postgres cluster using built in expose trait.

@wonderflow
Copy link
Collaborator

@MdSahil-oss Hi, does this addon work? We can use postres-expose trait you added instead of built-in expose trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants