Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Hive-operator #655

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Conversation

MdSahil-oss
Copy link
Contributor

@MdSahil-oss MdSahil-oss commented Mar 14, 2023

Description of your changes

Fixes kubevela/kubevela#5133

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Signed-off-by: MdSahil-oss <[email protected]>
Signed-off-by: MdSahil-oss <[email protected]>
Signed-off-by: MdSahil-oss <[email protected]>
Signed-off-by: MdSahil-oss <[email protected]>
Signed-off-by: MdSahil-oss <[email protected]>
Signed-off-by: MdSahil-oss <[email protected]>
@MdSahil-oss MdSahil-oss changed the title WIP: Addon Hive-operator Addon Hive-operator Mar 18, 2023
Signed-off-by: MdSahil-oss <[email protected]>
@MdSahil-oss
Copy link
Contributor Author

@wonderflow @wangyikewxgm Please review this addon :)

**Minio**

```shell
helm install minio \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. can we use vela application or leverage addon for this installation?
  2. the further question is: if I were the user, I have already learned helm install, why I don't use helm install to install hive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended addon capabililty to install dependencies at the time of addon installation.

Copy link
Member

@charlie0129 charlie0129 Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I don't think this conversation is resolved, yet. What @wonderflow means is this addon needs to have its distinct advantages that will benfit users compared to helm, otherwise the user would chose helm instead. Not just on the first hands-on, but also on subsequent deployments. I don't have a good knowledge about Hive, but here are some possible improvements, which are just my thoughts on this particular issue.

For example, vela Definitions provide an easy way to spin up complex things. In this particular addon, you have 3 components hive-cluster, s3-connection and secret-class that must be applied in order to have a functional hive cluster. Can this process be simplified? For example, can the user spin up a hive cluster with just one well-designed component? That well-designed component creates several resources under the hood, abstracts away tedious details from user while maintaining a certain level of customizability. And this is what makes vela or vela addons apart from typical helm installation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlie0129 for explanation. And it makes sence to have a simplified installation process. I think I should create a new component that create all hive related resources at once and make hive-cluster running in the cluster.

hive-postgres-cluster-metastore-default 1/1 76s
```

For more visit on the website https://docs.stackable.tech/home/stable/hive/index.html.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide some information here about how to use the hive cluster.

port: 9000
accessStyle: Path
credentials:
secretClass: hive-s3-secret-class
Copy link
Member

@charlie0129 charlie0129 Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put all these (including the single-component Applications below) into one single Application that the user can run and test? If used in this way, it is essentially the same as applying a bunch of yamls. The benfit of vela applications are gone.

```

```shell
$ vela ls -A | grep hive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try vela status?

properties: {
repoType: "helm"
url: "https://charts.min.io/"
chart: "minio"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is minio mandatory? If not, I don't think minio should be baked in by default. If this is not a mandatory component, then let the user decide whether they need it. For example, use addon parameters to let them customize or provide installation instructions for minio in readme for quick starts.

@MdSahil-oss
Copy link
Contributor Author

I'm closing this PR here because hive-operator gives an error on runnning, I'll open this PR when would be fixed.

@charlie0129
Copy link
Member

You can draft this pr, actually, without closing it.

@MdSahil-oss MdSahil-oss reopened this Mar 20, 2023
@MdSahil-oss MdSahil-oss marked this pull request as draft March 20, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]make hive as an addon
3 participants