Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add version requirement for clickhouse #512

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented Oct 22, 2022

Signed-off-by: Charlie Chiang [email protected]

Description of your changes

Add version requirement for clickhouse addon. Since it uses multiple comprehensions per list, which is available in CUE v3.0, we need Vela v1.6.0-alpha.1 and later for CUE v0.4.3

components: [
dashboard, operator,
if parameter.grafanaDashbord {
grafanaDashboardClickhouseOperator
},
]

Fixes part of #511

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG
Copy link
Collaborator

/cc @wonderflow

@wonderflow wonderflow merged commit 302c169 into kubevela:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants