Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting logs from MTV UI #569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Getting logs from MTV UI #569

wants to merge 1 commit into from

Conversation

RichardHoch
Copy link
Collaborator

@RichardHoch RichardHoch commented Oct 10, 2024 •
edited
Loading

MTV 2.7

Resolves https://issues.redhat.com/browse/MTV-808 by updating the description of how to view and download logs from the UI.
Also updates the descriptions of running migration plans and of plan options.
Previews:

@RichardHoch RichardHoch marked this pull request as ready for review October 14, 2024 13:55
@RichardHoch RichardHoch force-pushed the get_logs_ui branch 2 times, most recently from 16b280f to e6a15a1 Compare October 14, 2024 13:58
@RichardHoch RichardHoch changed the title WIP -- Getting logs from MTV UI Getting logs from MTV UI Oct 14, 2024
@RichardHoch
Copy link
Collaborator Author

@nunzy1 @mpershina Thanks for your comments, I made many of the changes you suggested. Please review the PR again. Thanks.

@RichardHoch
Copy link
Collaborator Author

@sgratch Please review this PR.

sgratch
sgratch reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardHoch lgtm, few comments to consider fixing.

documentation/modules/running-migration-plan.adoc Show resolved Hide resolved
documentation/modules/migration-plan-options-ui.adoc Outdated Show resolved Hide resolved
documentation/modules/migration-plan-options-ui.adoc Outdated Show resolved Hide resolved
documentation/modules/migration-plan-options-ui.adoc Outdated Show resolved Hide resolved
@RichardHoch
Copy link
Collaborator Author

@sgratch Thanks for your comments. I made the changes you suggested. Please review this PR again. Thanks!

sgratch
sgratch suggested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one small fix.

documentation/modules/migration-plan-options-ui.adoc Outdated Show resolved Hide resolved
@RichardHoch RichardHoch force-pushed the get_logs_ui branch 2 times, most recently from 7131061 to 6958a03 Compare November 7, 2024 12:43
@RichardHoch
Copy link
Collaborator Author

@sgratch I made the change you suggested. Please review this PR again. Thanks.

sgratch
sgratch approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@sgratch sgratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichardHoch
Copy link
Collaborator Author

@anarnold97 I made the changes you suggested. Please review this PR again. Thanks.

@RichardHoch
Copy link
Collaborator Author

@anarnold97 @nunzy1 Thank you for your comments. I made the changes you suggested, please review this PR again. thanks.

anarnold97
anarnold97 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one wee change... other than that LGTM

@RichardHoch
Copy link
Collaborator Author

RichardHoch commented Nov 21, 2024 •
edited
Loading

@anarnold97 Made the change you suggested. Please review again. If good, please merge and publish. Thanks.

@RichardHoch
Copy link
Collaborator Author

@anarnold97 I had a merge conflict with the new warning message. #590 I fixed it, but please double-check that the warning message appears in the right place in running-migration-plan.adoc , which is modified in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpershina mpershina mpershina left review comments

@nunzy1 nunzy1 nunzy1 left review comments

@sgratch sgratch sgratch approved these changes

@anarnold97 anarnold97 Awaiting requested review from anarnold97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RichardHoch @nunzy1 @sgratch @mpershina @anarnold97