Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MTV-709] Make region and project required fields when creating a new provider #730

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[MTV-709] Make region and project required fields when creating a new provider #730

merged 1 commit into from
Sep 20, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 19, 2023 •
edited
Loading

Ref: https://issues.redhat.com/browse/MTV-709

Issue:
The OpenStack provider created on UI using one of the following authentication types is always on staging status:

Application credential ID
Application credential name
Token with user ID
Token with user name

Cause of issue:
Forklift reuire region name to complete the inventory collection ( see: kubev2v/forklift#462 )

Fix:
Add region name and project name as mandatory fields.

Screenshots:

Uploading screenshot-localhost_9000-2023.09.20-11_16_04.png…

@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Sep 19, 2023
@yaacov yaacov added this to the 2.5.1 milestone Sep 19, 2023
@yaacov
Copy link
Member Author

yaacov commented Sep 19, 2023

@ahadas hi,
when authenticating with Token with user ID we have both projectID and projectName

Options:
a. this is not a problem actual a problem for users, they can enter both
b. remove the option to validate using Token with user ID
c. make it a special case where the user don't need to enter projectName

WDYT?

@yaacov
Copy link
Member Author

yaacov commented Sep 19, 2023

Update
After off line discussion the projectName and projectID needs fixing

@yaacov yaacov force-pushed the make-project-and-region-required-when-creating-provider branch 2 times, most recently from f528de3 to 2dd9498 Compare September 20, 2023 07:51
@yaacov yaacov force-pushed the make-project-and-region-required-when-creating-provider branch from 2dd9498 to 895abc8 Compare September 20, 2023 07:54
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
65.0% 65.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@yaacov yaacov merged commit b5a028f into kubev2v:main Sep 20, 2023
4 of 5 checks passed
sgratch added a commit to sgratch/forklift-console-plugin that referenced this pull request Sep 20, 2023
@sgratch
Add region and project fields to the OpenStack Credentials view page
bceb191 
As a followup to fix
kubev2v#730, need to add
the Region and Project fields to the OpenStack Credentials view mode
dialog as well.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
1 participant
@yaacov