Provider details page #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code changes: 1. use StandardPage list component 2. entity list is produced by merging results from k8s API and exsting Forklift inventory REST API. 3. actions in the table (kebab actions) are provided via extension point 'console.action/provider' Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Code changes: 1. generic (empty) details page is provided via extentsion point 'console.page/resource/details' 2. actions in the details page are provided via extension points 'console.action/resource-provider' 3. inventory tab (part of the details) is provided via extension point 'console.tab/horizontalNav' Signed-off-by: Radoslaw Szwajkowski <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
Let's keep this PR a bit longer for reference. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
Let's wait a bit longer:) |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 15 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from PR #33
Code changes:
1. generic (empty) details page is provided via extension point
'console.page/resource/details'
2. actions in the details page are provided via extension points
'console.action/resource-provider'
3. inventory tab (part of the details) is provided via extension point
'console.tab/horizontalNav'