Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 improve theme and error message #251

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Tusharjain123
Copy link

Description

Related Issue

Fixes #<issue_number>

Changes Made

  • Updated ...
  • Refactored ...
  • Fixed ...
  • Added tests for ...

Checklist

Please ensure the following before submitting your PR:

  • I have reviewed the project's contribution guidelines.
  • I have written unit tests for the changes (if applicable).
  • I have updated the documentation (if applicable).
  • I have tested the changes locally and ensured they work as expected.
  • My code follows the project's coding standards.

Screenshots or Logs (if applicable)

Additional Notes

@Tusharjain123
Copy link
Author

@clubanderson ptal

@MAVRICK-1
Copy link
Member

MAVRICK-1 commented Feb 27, 2025

@Tusharjain123 can u provide video of the changes you made ?

@Tusharjain123
Copy link
Author

Theme and layout changes to
image -> Dashboard page
image -> Menu Bar
image -> ITS page
image -> WDS page

More understandable error message
image -> Workload Creation Error Message

@clubanderson
Copy link
Contributor

@onkar717 @RealRTorres @kunal-511 what are your thoughts on this? Is their more work needed here to cover all UI elements?

@Tusharjain123
Copy link
Author

@onkar717 @RealRTorres @kunal-511 what are your thoughts on this? Is their more work needed here to cover all UI elements?

Yes, there are some changes left, which I will be covering in the next PR, which contains removal of repetitive elements, so that all the pages will look uniform

@clubanderson
Copy link
Contributor

ok, let these 3 folks review and lets see what they think.

@RealRTorres
Copy link
Contributor

RealRTorres commented Feb 27, 2025

First off, I like the changing the text and everything to blue from purple. It makes it look uniform and matches Kubestellar's theme.

I like the status colors for active, inactive, and pending for the clusters management table. However, the text-color of that activity status should be a darker green color for more contrast and make it easier for users to read.

Additionally, I previously added the checkmark emoji as an extra visual cue for color-blind users. Right now, it looks a bit clunky because there's no space between it and the word "Active." Instead, can you replace the checkmark emoji with an MUI checkmark icon (or something similar) and move it to the right side of the status sign?

Ideally, it should look something like this:
image

It looks great so far! Let me know what you think or if you have any questions.

@Tusharjain123
Copy link
Author

First off, I like the changing the text and everything to blue from purple. It makes it look uniform and matches Kubestellar's theme.

I like the status colors for active, inactive, and pending for the clusters management table. However, the text-color of that activity status should be a darker green color for more contrast and make it easier for users to read.

Additionally, I previously added the checkmark emoji as an extra visual cue for color-blind users. Right now, it looks a bit clunky because there's no space between it and the word "Active." Instead, can you replace the checkmark emoji with an MUI checkmark icon (or something similar) and move it to the right side of the status sign?

Ideally, it should look something like this: image

It looks great so far! Let me know what you think or if you have any questions.

Yepp that is looking somewhat clunky. I will change that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants