Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssh formatting exception bug when executing commands #2406

Merged

Conversation

dbbDylan
Copy link

@dbbDylan dbbDylan commented Sep 14, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • String formatting directly by fmt.Sprintf may cause unexpected error when executing a single command as a result of multiple double-quote transpositions. The more safe way is to use exec.Command function.
  • Fix from file:// to file:/// in init_repository.yaml

For more information on release notes see: https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md
-->

- fix: ssh formatting exception bug when executing commands
- fix: from `file://` to `file:///` in `init_repository.yaml`

@kubesphere-prow kubesphere-prow bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2024
WARNING: Use `nolint:gosec` annotation
Copy link

This PR has multiple commits, and the default merge method is: squash.
You can request commits to be merged using the label: tide/merge-method-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dbbDylan
Copy link
Author

This way can correctly execute multi-line commands, but use one nolint:gosec annotation to avoid lint error.

@kubesphere-prow kubesphere-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
Copy link

sonarcloud bot commented Sep 18, 2024

@redscholar redscholar added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dbbDylan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot merged commit e4957a6 into kubesphere:feature-gitops Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants