Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tower leader election parameter config #2217

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update tower leader election parameter config #2217

merged 1 commit into from
Jul 25, 2023

Conversation

iawia002
Copy link
Contributor

There's no need to start leader election when there's only one replica

ref kubesphere/kubesphere#5855

/cc @pixiake

@ks-ci-bot ks-ci-bot requested a review from pixiake July 21, 2023 09:31
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2023
@iawia002
Copy link
Contributor Author

/cherry-pick release-3.4

@ks-ci-bot
Copy link
Collaborator

@iawia002: once the present PR merges, I will cherry-pick it on top of release-3.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Jul 25, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: de322b23baf2413d391fb1608c8a6dc9220f7b99

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@ks-ci-bot ks-ci-bot merged commit 97630cb into kubesphere:master Jul 25, 2023
2 checks passed
@iawia002 iawia002 deleted the tower branch July 25, 2023 07:49
@ks-ci-bot ks-ci-bot mentioned this pull request Jul 25, 2023
Merged
@ks-ci-bot
Copy link
Collaborator

@iawia002: new pull request created: #2222

In response to this:

/cherry-pick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixiake pixiake Awaiting requested review from pixiake

Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iawia002 @ks-ci-bot @pixiake