Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [TKC-2691] add escape / unescape dots for workflow templates #5938

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: [TKC-2691] add escape / unescape dots for workflow templates #5938

merged 1 commit into from
Oct 16, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Oct 16, 2024 •
edited
Loading

Pull request description

To store workflow templates in mongo we need escape dots in labels, etc.. so this adds new methods for templates.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@povilasv povilasv marked this pull request as ready for review October 16, 2024 08:47
@povilasv povilasv requested a review from a team as a code owner October 16, 2024 08:47
@povilasv povilasv merged commit 451fb22 into main Oct 16, 2024
24 checks passed
@povilasv povilasv deleted the escape-dots branch October 16, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @vsukhin