feat(TKC-1581): add mechanism to build Kubernetes resources for the TestWorkflow #5096
Conversation
… from TestWorkflow
rangoo94
requested review from
exu,
nicufk,
vsukhin,
vLia,
povilasv and
dejanzele
as code owners
✅ Deploy Preview for testkube-docs-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5096 +/- ##
===========================================
+ Coverage 30.47% 31.22% +0.75%
===========================================
Files 315 333 +18
Lines 28381 30070 +1689
===========================================
+ Hits 8648 9390 +742
- Misses 18899 19801 +902
- Partials 834 879 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| ) | ||
|
|
||
| const ( | ||
| defaultImage = "busybox:1.36.1" |
There was a problem hiding this comment.
shouldn't it be configurable parameter?
There was a problem hiding this comment.
Default is already configurable on the TestWorkflow level, as you may set top-level container: { image: "another-default-image" }. We could add some environment variable on API Server level to default the default though, if you want 🙂 I'm not sure if it's worth too, considering that we will likely have some global TestWorkflowTemplate, that will be automatically added to all of the TestWorkflows, where it could be configured (with top-level container settings, as above).
When it comes to the other properties, like internal or data directory, I'm considering that we could add in the future option to pass another property to the TestWorkflow, like internal: { dataDirectory: {path string, volumeName string} } or something like that
There was a problem hiding this comment.
ok, let's see, if we have any questions about it
| _, err = s.Clientset.CoreV1().ConfigMaps(s.Namespace).Create(context.Background(), &item, metav1.CreateOptions{}) | ||
| if err != nil { | ||
| return s.BadRequest(c, errPrefix, "creating configmap", err) | ||
| } |
There was a problem hiding this comment.
do we clear them after job finish?
There was a problem hiding this comment.
We will, but not at this point. The TKC-1651 ticket is for building the Controller, which will be handling the Job/Pod/Containers events, logs, and the cleanup 👍 I'm working on that in this very moment 🙂
rangoo94
deleted the
dawid/feat/TKC-1581-testworkflows-build-kubernetes-resources
branch
…estWorkflow (#5096) * feat(TKC-1581): adjust schema for TestWorkflow CRD adjustments * chore(TKC-1581): update testkube-operator * feat(TKC-1581): add initial mechanism for building Kubernetes objects from TestWorkflow * feat(TKC-1581): add basic API endpoint for execution TestWorkflows * chore(TKC-1581): clean code and add tests * feat(TKC-1581): support "delay" step clause * chore(TKC-1581): move init process arg names to constants
…estWorkflow (#5096) * feat(TKC-1581): adjust schema for TestWorkflow CRD adjustments * chore(TKC-1581): update testkube-operator * feat(TKC-1581): add initial mechanism for building Kubernetes objects from TestWorkflow * feat(TKC-1581): add basic API endpoint for execution TestWorkflows * chore(TKC-1581): clean code and add tests * feat(TKC-1581): support "delay" step clause * chore(TKC-1581): move init process arg names to constants
…estWorkflow (#5096) * feat(TKC-1581): adjust schema for TestWorkflow CRD adjustments * chore(TKC-1581): update testkube-operator * feat(TKC-1581): add initial mechanism for building Kubernetes objects from TestWorkflow * feat(TKC-1581): add basic API endpoint for execution TestWorkflows * chore(TKC-1581): clean code and add tests * feat(TKC-1581): support "delay" step clause * chore(TKC-1581): move init process arg names to constants
Pull request description
Checklist (choose whats happened)
Fixes