Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source for running scripts #5015

Merged
merged 12 commits into from
Mar 4, 2024
Merged

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Feb 15, 2024

Pull request description

Fix #5004

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for testkube-docs-preview ready!

Name Link
🔨 Latest commit dfbfc7b
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/65e6052e7072d200080930fb
😎 Deploy Preview https://deploy-preview-5015--testkube-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 31.30%. Comparing base (fdd6039) to head (dfbfc7b).
Report is 1158 commits behind head on develop.

Files with missing lines Patch % Lines
contrib/executor/init/pkg/runner/runner.go 0.00% 6 Missing and 3 partials ⚠️
pkg/mapper/tests/openapi_kube.go 0.00% 4 Missing ⚠️
pkg/scheduler/test_scheduler.go 0.00% 3 Missing and 1 partial ⚠️
pkg/api/v1/client/test.go 0.00% 2 Missing ⚠️
pkg/mapper/tests/kube_openapi.go 50.00% 1 Missing ⚠️
pkg/mapper/testsuiteexecutions/mapper.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5015      +/-   ##
===========================================
+ Coverage    30.58%   31.30%   +0.72%     
===========================================
  Files          333      333              
  Lines        30106    30125      +19     
===========================================
+ Hits          9208     9432     +224     
+ Misses       20042    19809     -233     
- Partials       856      884      +28     
Flag Coverage Δ
integrationtests 5.69% <0.00%> (-0.01%) ⬇️
unittests 27.42% <4.54%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contrib/executor/init/pkg/runner/runner.go Outdated Show resolved Hide resolved
pkg/executor/containerexecutor/tmpl.go Outdated Show resolved Hide resolved
@vsukhin vsukhin merged commit 2e92b18 into develop Mar 4, 2024
10 checks passed
@vsukhin vsukhin deleted the vsukhin/fix/script-scource-command branch March 4, 2024 17:37
vsukhin added a commit that referenced this pull request Mar 7, 2024
* fix: source for running scripts

* feat: source scripts field

* fix: process source scripts flag

* fix: template for source scripts

* fix: dep updare

* fix: remove source for prebuilt executors

* docs: source scripts flag

* fix: dep update
# Conflicts:
#	go.mod
#	go.sum
vsukhin added a commit that referenced this pull request Mar 11, 2024
* fix: source for running scripts

* feat: source scripts field

* fix: process source scripts flag

* fix: template for source scripts

* fix: dep updare

* fix: remove source for prebuilt executors

* docs: source scripts flag

* fix: dep update
# Conflicts:
#	go.mod
#	go.sum
exu pushed a commit that referenced this pull request Apr 2, 2024
* fix: source for running scripts

* feat: source scripts field

* fix: process source scripts flag

* fix: template for source scripts

* fix: dep updare

* fix: remove source for prebuilt executors

* docs: source scripts flag

* fix: dep update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prerun.sh is not run using source command
4 participants