refactor: remove isListLoading prop (#980)

kubeshop · Dec 18, 2023 · eb85a68 · eb85a68
1 parent f1d945a
commit eb85a68
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 24 deletions.
diff --git a/packages/web/src/components/organisms/EntityView/EntityView.tsx b/packages/web/src/components/organisms/EntityView/EntityView.tsx
@@ -48,7 +48,6 @@ const EntityView: React.FC<EntityViewBlueprint> = props => {
     entity,
     initialFiltersState,
     isFetching,
-    isListLoading,
     isLoading,
     itemKey,
     pageDescription,
@@ -150,12 +149,6 @@ const EntityView: React.FC<EntityViewBlueprint> = props => {
     }
   }, [isFetching]);
 
-  useEffect(() => {
-    if (!isListLoading) return;
-
-    setFirstTimeLoading(true);
-  }, [isListLoading]);
-
   const DefaultViewComponent: React.FC<ViewComponentBaseProps> = useMemo(
     () => componentProps =>
       (

diff --git a/packages/web/src/components/pages/TestSuites/TestSuitesList/TestSuitesList.tsx b/packages/web/src/components/pages/TestSuites/TestSuitesList/TestSuitesList.tsx
@@ -25,13 +25,7 @@ import TestSuiteCreationModalContent from './TestSuiteCreationModalContent';
 
 const PageDescription: React.FC = () => <>Explore your test suites at a glance...</>;
 
-interface TestSuitesListProps {
-  isListLoading?: boolean;
-}
-
-const TestSuitesList: React.FC<TestSuitesListProps> = props => {
-  const {isListLoading} = props;
-
+const TestSuitesList: React.FC = () => {
   const isSystemAvailable = useSystemAccess(SystemAccess.system);
   const [filters, setFilters] = useTestSuitesField('filters');
   const pageTitleAddon = useTestsSlotFirst('testSuitesListTitleAddon');
@@ -90,7 +84,6 @@ const TestSuitesList: React.FC<TestSuitesListProps> = props => {
       isLoading={isLoading || !isSystemAvailable}
       isFetching={isFetching}
       onAdd={openCreateModal}
-      isListLoading={isListLoading ?? false}
     />
   );
 };

diff --git a/packages/web/src/components/pages/Tests/TestsList/TestsList.tsx b/packages/web/src/components/pages/Tests/TestsList/TestsList.tsx
@@ -33,13 +33,7 @@ const PageDescription: React.FC = () => (
   </>
 );
 
-interface TestsListProps {
-  isListLoading?: boolean;
-}
-
-const TestsList: React.FC<TestsListProps> = props => {
-  const {isListLoading} = props;
-
+const TestsList: React.FC = () => {
   const isSystemAvailable = useSystemAccess(SystemAccess.system);
   const [filters, setFilters] = useTestsField('filters');
 
@@ -96,7 +90,6 @@ const TestsList: React.FC<TestsListProps> = props => {
       isLoading={isLoading || !isSystemAvailable}
       isFetching={isFetching}
       onAdd={openCreateModal}
-      isListLoading={isListLoading ?? false}
     />
   );
 };

diff --git a/packages/web/src/models/entity.ts b/packages/web/src/models/entity.ts
@@ -14,7 +14,6 @@ export interface EntityViewBlueprint {
   entity: Entity;
   initialFiltersState: TestFilters | TestSuiteFilters;
   isFetching: boolean;
-  isListLoading: boolean;
   isLoading: boolean;
   itemKey: string;
   pageTitle: string;