Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to pass YAML string as a global template #985

Merged
merged 1 commit into from
Feb 3, 2025
Merged

feat: make it possible to pass YAML string as a global template #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/testkube-api/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,11 @@ spec:
{{- if .Values.global.testWorkflows.globalTemplate.enabled }}
{{- if .Values.global.testWorkflows.globalTemplate.inline }}
- name: TESTKUBE_GLOBAL_WORKFLOW_TEMPLATE_INLINE
{{- if and .Values.global.testWorkflows.globalTemplate.spec (kindIs "map" .Values.global.testWorkflows.globalTemplate.spec) }}
value: {{ toJson .Values.global.testWorkflows.globalTemplate.spec | quote }}
{{- else }}
value: {{ toJson (fromYaml .Values.global.testWorkflows.globalTemplate.spec) | quote }}
{{- end }}
{{- else }}
- name: TESTKUBE_GLOBAL_WORKFLOW_TEMPLATE_NAME
value: "{{ .Values.global.testWorkflows.globalTemplate.name }}"
Expand Down
2 changes: 1 addition & 1 deletion charts/testkube-api/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ global:
external: false
inline: false
name: global-template
spec: {}
spec: null

### @section Common parameters
## Kubernetes version (using Helm capabilities if not set)
Expand Down
2 changes: 1 addition & 1 deletion charts/testkube/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ global:
# -- Should the global template sourced inline instead of CRD? (otherwise its resource is created from spec below)
inline: false
# -- Specification for the global template
spec: {}
spec: null
# spec:
# pod:
# imagePullSecrets:
Expand Down
Loading