fix: [TKC-1851] Add registry configuration for workflows docker images #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejanzele
reviewed
Apr 16, 2024
jmorante-ks
changed the title
rangoo94
reviewed
Apr 16, 2024
rangoo94
reviewed
Apr 17, 2024
rangoo94
reviewed
Apr 18, 2024
Comment on lines
+381
to
+382
| # -- Test Workflows image k8s secret for private registries | ||
| pullSecrets: [] |
There was a problem hiding this comment.
This should be deleted, same as for toolkit
rangoo94
approved these changes
Apr 18, 2024
rangoo94
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Updating Chart versions is missing though, not sure if it's important @dejanzele
nicufk
added a commit
that referenced
this pull request
Apr 18, 2024
#809) * fix: add registry configuration for workflows doecker images * fix: image tags * fix: remove pullSecrets
vsukhin
added a commit
that referenced
this pull request
May 16, 2024
* fix: disable nats box * fix: typo in natsbox commented param * fix: added comments to values files * fix: charts version bump * fix: added empty lintconf to bypass error * fix: removed lintconf as there is no file * fix: linter suggestions * fix lint values.yaml * fix: removed maintainers validation * fix: space in comment * fix: space in comment * Update executors.json * Update executors.json * fix: on develop push * fix: remove ref to test repo * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * feat: side car container for slave pod * fix: rename slave od source * fix: remove unused fields * fix: logs source * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * fix: add secret list role * Update executors.json * Update Chart.yaml files * Feature: Add support for overriding NATS image options (#781) Co-authored-by: ypoplavs <[email protected]> * Update executors.json * fix: update cloud variables to pro * Update executors.json * fix: allow to override data volume * fix: changed condition * fix: removed unused volumerequest * fix: removed unused volumerequest * fix: chart versionb * fix: chart * fix: chart * Update executors.json * Update executors.json * fix: Unexpected EOF in pvc-template * enbled ingress for api * enable logsV2 (#789) * enable API ingress for xyz env * Update executors.json * Update executors.json * Update executors.json * Update executors.json * fix: rollback changed artifact volume * Update executors.json * fix: dont attach init when global data directory used (#792) * fix: dont attach init when global data directory used * fix update chart version * fix update chart version * fix update chart version * fix linter errors * update ci * remove testing branch * Update executors.json * Update executors.json * Enable logsv2 for stage env * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update Chart.yaml files * Update Chart.yaml file * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update Chart.yaml file * feat: inject custom ca (#799) (#800) * feat: inject custom ca (#799) * feat: inject custom ca into agent * feat: custom ca job template * feat: custom ca job scraper template * feat: custom ca slave pod template * fix: set env var to inject ca into runners * fix: duplicate custom ca secret ref in parent chart * Update Chart.yaml file * feat(TKC-1808): allow to pass `run.shell` for TestWorkflow commands * Update executors.json * Update executors.json * fix chart lint * Update Chart.yaml files * Update executors.json * feat: add global nodeSelectors, tolerations, affinity (#803) * add global nodeSelectors, tolerations, affinity * Update executors.json * Update Chart.yaml files * Update executors.json * fix: logs version (#806) * Update Chart.yaml files * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update Chart.yaml files * Update executors.json * feat: use default storage class name * feat: add default storage template support to templates * docs: add helm var desc * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * feat(testworkflows): update CRDs to support matrix/shards for execute step * Update executors.json * fix: rollback changess (#811) * Update executors.json * Update executors.json * Update executors.json * feat: test workflow cron job fields * fix: Group field for cron job tempate * feat(testworkflows): add support for built-in TestWorkflow templates (#813) * fix: [TKC-1851] Add registry configuration for workflows docker images (#809) * fix: add registry configuration for workflows doecker images * fix: image tags * fix: remove pullSecrets * Update executors.json * Update Chart.yaml file * feat(testworkflows): add support for global TestWorkflowTemplate (#816) * Update executors.json * Update Chart.yaml files * Update Chart.yaml files * Update Chart.yaml file * feat: Testkube - official test workflow templates (beta) (#815) * official test workflow templates (beta) - artillery, cypress, gradle, jmeter, k6, maven, playwright, postman * image - quotes added * Update charts/testkube-api/templates/testworkflows/builtin-templates/artillery.yaml Co-authored-by: Dawid Rusnak <[email protected]> * artillery template updated * test workflow templates - container replaced with run * updated after CR * postman template - escaped config * typo fixed * postman - escaping changed * templates - escaping added * official workflow templates - moved to testkube-operator * test workflow templates - values files updated * test workflow templates - helm post-install/post-upgrade hooks, weight, delete-policy --------- Co-authored-by: Dawid Rusnak <[email protected]> * Update Chart.yaml file * fix: install common TestWorkflowTemplates in the context of testkube-api, to make it working for multi-namespace agents (#818) * Update Chart.yaml file * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * chore(testworkflows): update CRDs * Update executors.json * Update executors.json * chore: template url values * feat(testworkflows): add pausing steps * chore(testworkflows): replace `paused` to be boolean * Update Chart.yaml file * Update executors.json * feat: add testworkflow for triggers * feat(testworkflows): support more advanced Pod configuration (#825) * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * feat: workflow events * fix: update comment * fix: slack config * fix: update slack template * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * change update strategy for mongo * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * disable testConnection pods (#828) * Update Chart.yaml file * Update Chart.yaml files * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update executors.json * feat: namespace for test workflow job config * Update executors.json * Update executors.json * feat(testworkflows): update CRDs to add activeDeadlineSeconds for job (#832) * Update executors.json * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update Chart.yaml files * Update Chart.yaml files * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update Chart.yaml file * fix: pull from git server with private-ca certs (#837) Only covers pre-built and container executors. * Update executors.json * feat: events role * fix: test trigger event causes * fix: enable k8s events * fix: enabale k8s events env * feat(testworkflows): update CRDs to add parallel step definition (#833) * feat(testworkflows): update CRDs to add parallel step definition * feat(testworkflows): add distribute/evenly template * Update executors.json * Update executors.json * Update executors.json * Update Chart.yaml files * Update executors.json * fix: merge conflicts * feat: add minio metrics (#834) --------- Co-authored-by: Jacek Wysocki <[email protected]> Co-authored-by: kubeshop-bot <[email protected]> Co-authored-by: Emil Davtyan <[email protected]> Co-authored-by: Emil Davtyan <[email protected]> Co-authored-by: Michael Walsh <[email protected]> Co-authored-by: ypoplavs <[email protected]> Co-authored-by: Lilla Vass <[email protected]> Co-authored-by: ypoplavs <[email protected]> Co-authored-by: vsukhin <[email protected]> Co-authored-by: emil2k <[email protected]> Co-authored-by: Dawid Rusnak <[email protected]> Co-authored-by: nicufk <[email protected]> Co-authored-by: nicufk <[email protected]> Co-authored-by: Tomasz Konieczny <[email protected]> Co-authored-by: tkonieczny <[email protected]> Co-authored-by: rangoo94 <[email protected]> Co-authored-by: Delnat Wito <[email protected]> Co-authored-by: Wito <[email protected]> Co-authored-by: ypoplavs <[email protected]> Co-authored-by: Nelson Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
https://linear.app/kubeshop/issue/TKC-1851/[workday]-issue-configuring-testworkflows-to-use-private-registry
Checklist (choose whats happened)
Breaking changes
Changes
Fixes