feat: add an option to provide nameselector and scope in operator webhook #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsukhin
approved these changes
Mar 7, 2024
dejanzele
requested changes
Mar 7, 2024
dejanzele
reviewed
Mar 7, 2024
dejanzele
reviewed
Mar 7, 2024
| @@ -40,5 +44,8 @@ webhooks: | |||
| - UPDATE | |||
| resources: | |||
| - testtriggers | |||
| {{- if .Values.webhook.scope }} | |||
| scope: {{ .Values.webhook.scope }} | |||
There was a problem hiding this comment.
scope can be hardcoded to Namespaced as all our resources are namespace-scoped
dejanzele
reviewed
Mar 7, 2024
dejanzele
reviewed
Mar 7, 2024
charts/testkube/values.yaml
Outdated
| ## Limit which requests for namespaced resources are intercepted, by specifying a namespaceSelector. | ||
| namespaceSelector: [] | ||
| ## Scope specifies a scope to match. Valid values are "Cluster", "Namespaced", and "*". Default is "*". | ||
| scope: "" |
dejanzele
reviewed
Mar 7, 2024
dejanzele
reviewed
Mar 7, 2024
ypoplavs
added a commit
that referenced
this pull request
Mar 11, 2024
…hook (#762) * add an option to provide nameselector and scope in operator webhook
ypoplavs
added a commit
that referenced
this pull request
Mar 11, 2024
…hook (#762) * add an option to provide nameselector and scope in operator webhook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
As per user's request this PR enabled adding
namespaceSelectorto limit which requests are intercepted.Checklist (choose whats happened)
Breaking changes
Changes
Fixes