Feature/cloud services #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
matthyx
reviewed
Dec 2, 2024
pkg/dnsmanager/dns_manager.go
Outdated
| } | ||
|
|
||
| // Check for other common cloud providers | ||
| otherCloudDomains := []string{ |
There was a problem hiding this comment.
you should add ovhcloud.com domain names, since we're partners now
There was a problem hiding this comment.
not sure where to find them...
There was a problem hiding this comment.
I think there are some domains in *.ovh.net
There was a problem hiding this comment.
Currently we only care about aws anyway.
matthyx
reviewed
Dec 2, 2024
| if config.TimeoutSeconds == 0 { | ||
| config.TimeoutSeconds = 5 | ||
| config.TimeoutSeconds = int(defaultTimeout.Seconds()) |
There was a problem hiding this comment.
looks weird to have a duration just to extract an int... tell Claude I would have preferred defaultTimeoutSeconds here
There was a problem hiding this comment.
I actually like this, it's readable.
There was a problem hiding this comment.
yeah... and it's probably too late to change the config timeoutSeconds into timeoutDuration :(
matthyx
reviewed
Dec 2, 2024
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
matthyx
previously approved these changes
Dec 2, 2024
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview