Improving rule r0006 #410
Merged
Improving rule r0006 #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Schendel <[email protected]>
matthyx
reviewed
Nov 21, 2024
|
|
||
| // normalizeTokenPath removes timestamp directories from the path while maintaining | ||
| // the essential structure. Optimized for minimal allocations. | ||
| func normalizeTokenPath(path string) string { |
There was a problem hiding this comment.
do you have a time constraint on this? because splitting and joining strings are really wasteful
you can check how much fun we had with indexing strings in https://github.com/kubescape/storage/blob/2b75b33130a55255df7575dc473a49858e3e325d/pkg/registry/file/dynamicpathdetector/analyzer.go#L137
There was a problem hiding this comment.
Do you have a better suggestion? I am not that worried about performance because we first filter the prefix, wdyt?
matthyx
previously approved these changes
Nov 21, 2024
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Signed-off-by: Amit Schendel <[email protected]>
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview