Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/policy rules #399

Merged
merged 22 commits into from
Nov 18, 2024
Merged

Feature/policy rules #399

merged 22 commits into from
Nov 18, 2024

Conversation

afek854
Copy link
Contributor

@afek854 afek854 commented Nov 6, 2024

Overview

@afek854
Copy link
Contributor Author

afek854 commented Nov 6, 2024

Need to update storage in go.mod before

@afek854
Added tests
db059ae 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/policy_rules branch from 5b70325 to db059ae Compare November 6, 2024 08:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 marked this pull request as ready for review November 6, 2024 15:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 requested review from matthyx and amitschendel and removed request for matthyx November 7, 2024 07:19
@afek854 afek854 force-pushed the feature/policy_rules branch 2 times, most recently from 46cd39e to e076c4e Compare November 7, 2024 07:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854
Fixed rules test
d957650 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/policy_rules branch from e076c4e to d957650 Compare November 7, 2024 07:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

matthyx
matthyx reviewed Nov 7, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

1 similar comment
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch from c027851 to 66eed95 Compare November 14, 2024 11:57
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch from 10d0df5 to b136b1e Compare November 17, 2024 09:22
@afek854
Fixed init ops
b14a3b2 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/policy_rules branch from b136b1e to b14a3b2 Compare November 17, 2024 09:22
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch from 6adb040 to 1c0b04f Compare November 17, 2024 09:54
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch from 1c0b04f to e1583de Compare November 17, 2024 10:13
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch from e1583de to 74055f8 Compare November 17, 2024 11:20
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch 2 times, most recently from 3ace3da to c2f7fa4 Compare November 17, 2024 11:58
@afek854
Fixed component test
def694f 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/policy_rules branch from c2f7fa4 to def694f Compare November 17, 2024 12:00
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 force-pushed the feature/policy_rules branch 2 times, most recently from 2bc514e to 101ebc4 Compare November 17, 2024 12:44
@afek854
Update default rule binding
afb7631 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/policy_rules branch from 101ebc4 to afb7631 Compare November 17, 2024 12:50
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@afek854 afek854 requested a review from matthyx November 18, 2024 07:19
matthyx
matthyx reviewed Nov 18, 2024
View reviewed changes
pkg/applicationprofilemanager/v1/applicationprofile_manager.go
@@ -211,7 +223,7 @@ func (am *ApplicationProfileManager) monitorContainer(ctx context.Context, conta
}
}

func (am *ApplicationProfileManager) saveProfile(ctx context.Context, watchedContainer *utils.WatchedContainerData, namespace string) {
func (am *ApplicationProfileManager) saveProfile(ctx context.Context, watchedContainer *utils.WatchedContainerData, namespace string, initalizeOperations []utils.PatchOperation) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit ugly, but let's leave it like that for the moment

matthyx
matthyx approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, not an easy feat !

@afek854 afek854 merged commit 549e1a8 into main Nov 18, 2024
19 checks passed
@matthyx matthyx deleted the feature/policy_rules branch November 27, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx matthyx approved these changes

@amitschendel amitschendel Awaiting requested review from amitschendel

Assignees
No one assigned
Labels
None yet
Projects
KS PRs tracking
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afek854 @matthyx