update applicationprofile type #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthyx
force-pushed
the
bump-storage
branch
3 times, most recently
from
392bea9
to
347f0f8
Compare
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
force-pushed
the
bump-storage
branch
from
347f0f8
to
e7e846d
Compare
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
changed the title
PR Analysis
How to use
|
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
force-pushed
the
bump-storage
branch
from
549631b
to
d9c6b09
Compare
|
Summary:
|
matthyx
force-pushed
the
bump-storage
branch
from
603ab05
to
80e1ab7
Compare
|
Summary:
|
matthyx
force-pushed
the
bump-storage
branch
from
8f0b4a0
to
d94a5b7
Compare
|
Summary:
|
matthyx
force-pushed
the
bump-storage
branch
from
d94a5b7
to
9fab199
Compare
|
@Daniel-GrunbergerCA ready to review |
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
force-pushed
the
bump-storage
branch
from
9fab199
to
9a96516
Compare
|
Summary:
|
Daniel-GrunbergerCA
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Enhancement
PR Description:
This PR introduces several enhancements to the Application Profile Manager:
PR Main Files Walkthrough:
files:
main.go: The cluster name is now passed as an argument when creating the Application Profile Manager.pkg/applicationprofilemanager/v1/applicationprofile_manager.go: The Application Profile Manager structure now includes a cluster name. The CreateApplicationProfileManager function has been updated to accept the cluster name as an argument. Additional logic has been added to calculate and validate the WLID, find the container type and index, and save the application profile accordingly.pkg/applicationprofilemanager/v1/applicationprofile_manager_test.go: The test for the Application Profile Manager has been updated to pass the cluster name as an argument when creating the Application Profile Manager.pkg/k8sclient/k8sclient_mock.go: A new container with the name "log" and image "fluentbit" has been added to the mock workload.pkg/storage/storage_mock.go: The mock Application Profile now includes a list of containers, each with its own capabilities.pkg/utils/utils.go: The WatchedContainerData structure now includes a container type and index. New functions have been added to get and insert an Application Profile Container based on the container type and index.go.mod: The version of the storage package has been updated from v0.0.33 to v0.0.38.