Modified comments

Signed-off-by: Afek Berger <[email protected]>
kubescape · Nov 20, 2024 · a7cb3c8 · a7cb3c8
1 parent 549e1a8
commit a7cb3c8
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 4 deletions.
diff --git a/pkg/eventreporters/rulepolicy/rule_policy.go b/pkg/eventreporters/rulepolicy/rule_policy.go
@@ -21,7 +21,6 @@ func NewRulePolicyReporter(ruleManager rulemanager.RuleManagerClient, applicatio
 func (rpm *RulePolicyReporter) ReportEvent(eventType utils.EventType, event utils.K8sEvent, k8sContainerID string, allowedProcess string) {
 	rulesIds := rpm.ruleManager.EvaluateRulesForEvent(eventType, event)
 	for _, rule := range rulesIds {
-		// TODO: Add a check to see if the rule is using rule policy
 		rpm.applicationProfileManager.ReportRulePolicy(k8sContainerID, rule, allowedProcess, false)
 	}
 }
diff --git a/pkg/ruleengine/v1/r1010_symlink_created_over_sensitive_file_test.go b/pkg/ruleengine/v1/r1010_symlink_created_over_sensitive_file_test.go
@@ -27,7 +27,7 @@ func TestR1010SymlinkCreatedOverSensitiveFile(t *testing.T) {
 					{
 						Name: "test",
 						PolicyByRuleId: map[string]v1beta1.RulePolicy{
-							R1010ID: v1beta1.RulePolicy{
+							R1010ID: {
 								AllowedProcesses: []string{"/usr/sbin/groupadd"},
 							},
 						},

diff --git a/pkg/ruleengine/v1/r1011_ld_preload_hook_test.go b/pkg/ruleengine/v1/r1011_ld_preload_hook_test.go
@@ -142,7 +142,7 @@ func TestR1011LdPreloadHook(t *testing.T) {
 					{
 						Name: "test",
 						PolicyByRuleId: map[string]v1beta1.RulePolicy{
-							R1011ID: v1beta1.RulePolicy{
+							R1011ID: {
 								AllowedProcesses: []string{"test"},
 							},
 						},

diff --git a/pkg/ruleengine/v1/r1012_hardlink_created_over_sensitive_file_test.go b/pkg/ruleengine/v1/r1012_hardlink_created_over_sensitive_file_test.go
@@ -27,7 +27,7 @@ func TestR1012HardlinkCreatedOverSensitiveFile(t *testing.T) {
 					{
 						Name: "test",
 						PolicyByRuleId: map[string]v1beta1.RulePolicy{
-							R1012ID: v1beta1.RulePolicy{
+							R1012ID: {
 								AllowedProcesses: []string{"/usr/sbin/groupadd"},
 							},
 						},

diff --git a/tests/component_test.go b/tests/component_test.go
@@ -1123,6 +1123,7 @@ func Test_14_RulePoliciesTest(t *testing.T) {
 		t.Errorf("Error waiting for workload to be ready: %v", err)
 	}
 
+	// Wait for application profile to be ready
 	assert.NoError(t, endpointTraffic.WaitForApplicationProfile(80, "ready"))
 
 	// Add to rule policy symlink