Skip to content

[ko] use latest API syntax in JavaScript client example #50956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented May 18, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jihoon-seo May 18, 2025 11:47
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jmyung May 18, 2025 11:47
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2025
Copy link

netlify bot commented May 18, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cdd7ad4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6829c8b996ab6200086581a8
😎 Deploy Preview https://deploy-preview-50956--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax change looks in sync with 'en' PR https://github.com/kubernetes/website/pull/50887/files

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e023de8cc2e440264fac220041f511d38274e0f

Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit c8f641b into kubernetes:main May 26, 2025
6 checks passed
@Arhell Arhell deleted the ko-api branch May 26, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants