Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bump Docsy to 0.11.x #48726

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 14, 2024

ℹ️ this PR does not build for a local container preview

This PR aims to switch to the most recent Docsy 0.11.0 release. It builds on #48725 and precursor PRs.

I've opened it because I'd like help: I can't get the local container build image to build and work for v0.8.x, nor for v0.11.x

Many eyes should make the challenge here shallower.

/area web-development

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/en Issues or PRs related to English language labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2024
@sftim
Copy link
Contributor Author

sftim commented Nov 14, 2024

Now, we could use Hugo Modules. The trouble is: we're already a Go project and we already have a go.mod. Adding Hugo and Docsy into the mix there doesn't sound practical. Maybe it would be, with workspaces; even there, it'll be good to find a container solution so that contributors don't need to invest neurons and aeons in understanding how to set up a working local dev environment.

Copy link

netlify bot commented Nov 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9732ffc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67366af30dd22e0008170064
😎 Deploy Preview https://deploy-preview-48726--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jihoon-seo
Copy link
Member

jihoon-seo commented Nov 18, 2024

Regarding this comment, FYI: In Prow docs website, Docsy has been migrated from as a git submodule to as a Hugo module.
Please see:

@sftim
Copy link
Contributor Author

sftim commented Nov 18, 2024

Help with switching to a Hugo module is welcome! Feel free to open a PR - have a look at any of

as a potential starting point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants