Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move stable node feature specific jobs to release-blocking #33811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnishShah
Copy link
Contributor

After delaking eviction tests in kubernetes/kubernetes#127874 and kubernetes/kubernetes#126927, we have almost 2 weeks of green runs for eviction tests - https://testgrid.k8s.io/sig-node-containerd#node-kubelet-containerd-eviction.

We should make these jobs release-blocking since Eviction is a stable feature.

/sig node
/assign @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@AnishShah
Copy link
Contributor Author

/assign @yujuhong

@kannon92
Copy link
Contributor

These tests have been flaky for a long time. Even though they are green, why choose this over other green tests? I’d also like to see why the crio eviction jobs are still flaky. Containerd seems fine but crio still flakes on pid eviction.

tests for features like eviction, cpu/memory/topology managers are quite
stable. they should be considered release-blocking
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnishShah
Once this PR has been reviewed and has the lgtm label, please ask for approval from sergeykanzhelev. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AnishShah AnishShah changed the title move eviction jobs to release-blocking move stable node feature specific jobs to release-blocking Nov 21, 2024
@AnishShah
Copy link
Contributor Author

Even though they are green, why choose this over other green tests?

I intend to make the CPU, memory, and topology manager tests release-blocking again. These tests have been stable recently, so I believe it's appropriate to reinstate their blocking status. I'm not entirely sure why they were initially made non-blocking, but I suspect it was due to flakiness in the past.

@kannon92
Copy link
Contributor

So SIG-Node-Release-Blocking is a bit of a misnomer. Release does not look at that board to determine if there is a problem for the release. They would look at their sig-release board and we have a different process to include that to consider them "release blocking". Serial tests are mostly used by us to determine issues.

I'm happy to move these tests to release blocking but I wanted to clarify this.

@AnishShah
Copy link
Contributor Author

They would look at their sig-release board and we have a different process to include that to consider them "release blocking"

Sounds good. I was aware of this. What's the process to include these tests in sig-release dashboard? I can follow-up on this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: PRs - Needs Reviewer
Development

Successfully merging this pull request may close these issues.

5 participants