-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update etcd presubmit unit test jobs #32708
Update etcd presubmit unit test jobs #32708
Conversation
* Rename job to pull-etcd-unit-test-amd64. * Tune the resources requested/limits according to job runs on Grafana. * Update running arguments to match the current GitHub workflow. * Store output JUnit artifacts.
- -c | ||
- | | ||
export JUNIT_REPORT_DIR=${ARTIFACTS} | ||
GOOS=linux GOARCH=386 CPU=1 GO_TEST_FLAGS='-p=4' make test-unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are limiting to once CPU here should we also update requests/limits for the pod to 1 CPU?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it with what the original import to Prow had. Notice that it has optional: true
, as I'm monitoring these jobs and adjusting resources after some runs. Based on my observations from the integration tests, even when limited to one CPU, it may consume a bit more, especially at the beginning of the job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine setting it to one, though, as CPU limits in Kubernetes are soft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, let's leave it as is and tune later as needed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ivanvc: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Linking to kubernetes/k8s.io#6102. |
Update the current pull-etcd-unit-test job: adjust its memory based on Grafana, rename it to add the 386 job, update its running parameters, and store the JUnit results in Prow artifacts.
Add the 386 job moving forward with the Prow infra migration.