Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a task for updating k/k CHANGELOG OWNERS to docs handbook #2704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a task for updating k/k CHANGELOG OWNERS to docs handbook #2704

wants to merge 1 commit into from

Conversation

Vyom-Yadav
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Sometimes manual changes are required to the k/k CHANGELOG file. The Docs lead should have the access to approve any of those PRs.

Which issue(s) this PR fixes:

Issue #2695 (Not Fixes)

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@Vyom-Yadav
Copy link
Member Author

/assign @npolshakova @satyampsoni

@Vyom-Yadav Vyom-Yadav mentioned this pull request Dec 18, 2024
Open
npolshakova
npolshakova approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@npolshakova
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: npolshakova, Vyom-Yadav
Once this PR has been reviewed and has the lgtm label, please assign mickeyboxell for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolshakova npolshakova npolshakova approved these changes

@kcmartin kcmartin Awaiting requested review from kcmartin

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees

@npolshakova npolshakova

@satyampsoni satyampsoni

Labels
area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vyom-Yadav @npolshakova @k8s-ci-robot @satyampsoni