Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teams.yaml for adding niranjandarshann #5132

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

niranjandarshann
Copy link
Contributor

@divya-mohan0209 @dipesh-rawat
The PR www.github.com/kubernetes/website/pull/47782 is merged and raising this for seeking the approval of yours to add my username to the file under hindi reviewer role.

/assign @divya-mohan0209 @dipesh-rawat

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2024
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR. Welcome to the Hindi l10n team.

/lgtm
/approve (Unofficially giving the nod of approval; official PR approval can only be applied by sig-docs-leads for changes in this sig-docs/teams.yaml file.)

@Priyankasaggu11929
Copy link
Member

@niranjandarshann @divya-mohan0209 @dipesh-rawat – checking if PR changes are still needed? If yes, could we please get a formal approve from SIG Docs (Divya 🙂 )? Thanks!

@divya-mohan0209
Copy link
Contributor

Approve from my side!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, niranjandarshann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@divya-mohan0209
Copy link
Contributor

Thanks for flagging this @Priyankasaggu11929 ! Welcome to the team, @niranjandarshann :)

@k8s-ci-robot k8s-ci-robot merged commit 8f463b7 into kubernetes:main Nov 27, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants