-
Notifications
You must be signed in to change notification settings - Fork 5k
build: Tidy go files #21086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: Tidy go files #21086
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nirs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @nirs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its weird if I run go mod tidy in both folders it wont genearte a diff but if I do
go work sync
it will do tht but the diff is in the hack/go.mod do u mind trying go work sync?
lets make this PR ina way that runs go work sync automatically
It seems that recent dependencies changes were missing `go mod tidy`. Running it modified go.* files.
Running updates go.* files in hack/.
I run go work sync, it updated hack/go.mod. Posted at a new commit. I'm not sure what go work sync is doing, and when you don't want to run it. I think we should run this in the CI to ensure that all PRs are tidy. This will tell the author when go mod tidy or do work sync should run. |
Running go mod tidy in the hack directory updates its go.sum file.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
It seems that recent dependencies changes were missing
go mod tidy
. Running it modified go.* files.