-
Notifications
You must be signed in to change notification settings - Fork 5k
site: kvm2: Remove old part about needing to reboot #21020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: illume The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @illume! |
Hi @illume. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -34,7 +34,6 @@ The `minikube start` command supports 5 additional KVM specific flags: | |||
* `Machine didn't return an IP after 120 seconds` when firewall prevents VM network access [#3566](https://github.com/kubernetes/minikube/issues/3566) | |||
* `unable to set user and group to '65534:992` when `dynamic ownership = 1` in `qemu.conf` [#4467](https://github.com/kubernetes/minikube/issues/4467) | |||
* KVM VM's cannot be used simultaneously with VirtualBox [#4913](https://github.com/kubernetes/minikube/issues/4913) | |||
* On some distributions, libvirt bridge networking may fail until the host reboots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working with libvirt since 2013 and I never seen such issue. Maybe the issue is creating the network without presisting it. This should not happen if you follow the libvirt network configuration docs.
Minikube had a bug before 1.34 when it was deleting the libvirt network. This could result in missing network after you delete a cluster.
Deleting this looks good since we don't have any evidence and it may not be relevant for many years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added in #4989 - there was no discussion on this item.
I can confirm I didn't need to restart on debian nor ubuntu. Anything else to move forward with this? |
This note in the kvm2 driver docs about possibly needing to reboot I think is not true anymore.