Skip to content

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 21, 2025

Reverts #8652

only revert v1.13.1 as the image promotion failed.

[root@paco ~]# nerdctl pull registry.k8s.io/coredns/coredns:v1.13.1
registry.k8s.io/coredns/coredns:v1.13.1: resolving      |--------------------------------------| 
elapsed: 0.9 s                           total:   0.0 B (0.0 B/s)                                         
INFO[0001] trying next host - response was http.StatusNotFound  host=registry.k8s.io
FATA[0001] failed to resolve reference "registry.k8s.io/coredns/coredns:v1.13.1": registry.k8s.io/coredns/coredns:v1.13.1: not found 
[root@paco ~]# nerdctl pull registry.k8s.io/coredns/coredns:v1.13.0
registry.k8s.io/coredns/coredns:v1.13.0:                                          resolved       |++++++++++++++++++++++++++++++++++++++| 
index-sha256:da282c1983a1a330240e6e84eaec9b6120b0de0e7e29e92c44a6acd25f9e0238:    exists         |++++++++++++++++++++++++++++++++++++++| 
manifest-sha256:ec590162a6ca314b1e760f6591b26050267ae6d94d67e1926b44994fdad81200: exists         |++++++++++++++++++++++++++++++++++++++| 
config-sha256:6eaf5c6df60ede781f372972c43683948400ae5205de4d17cfc2c92914bc7766:   exists         |++++++++++++++++++++++++++++++++++++++| 
elapsed: 1.2 s     

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Oct 21, 2025

/cc @stp-ip @yashsingh74

@yashsingh74
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2025
@yashsingh74
Copy link
Member

@pacoxu will you be creating the separate PR for 1.13.1 ??

@ameukam
Copy link
Member

ameukam commented Oct 21, 2025

FYI, this will not remove the tag in the prod registry as we don't delete anything in prod. Promoting the same tag with a different SHA will break the promotion process.

@pacoxu
Copy link
Member Author

pacoxu commented Oct 21, 2025

FYI, this will not remove the tag in the prod registry as we don't delete anything in prod. Promoting the same tag with a different SHA will break the promotion process.

@ameukam The v1.13.1 image was not promoted due to that staging image was not ready when last PR was merged.

  • In that PR, it also include the v1.13.0 image, which was promoted successfully.

What I want do here it to revert the v1.13.1 image promotion here and then I will submit a PR to promote it again as the staging image should be ready now. Will this process work?

Or if the promotion can be done by some re-triggering(I think I don't have the permission).

@pacoxu
Copy link
Member Author

pacoxu commented Oct 21, 2025

Some context in kubernetes/kubernetes#133968 (comment).

@ameukam
Copy link
Member

ameukam commented Oct 21, 2025

FYI, this will not remove the tag in the prod registry as we don't delete anything in prod. Promoting the same tag with a different SHA will break the promotion process.

@ameukam The v1.13.1 image was not promoted due to that staging image was not ready when last PR was merged.

* In that PR, it also include the v1.13.0 image, which was promoted successfully.

What I want do here it to revert the v1.13.1 image promotion here and then I will submit a PR to promote it again as the staging image should be ready now. Will this process work?

Or if the promotion can be done by some re-triggering(I think I don't have the permission).

Thanks for the clarity. I should be fine to revert this.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9dea658 into kubernetes:main Oct 21, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants