Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCS PubSub topic for gs://kubernetes-ci-logs. #7264

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

michelle192837
Copy link
Contributor

This will allow TestGrid and Kettle to subscribe to this topic for updates, similar to what was done with gs://kubernetes-jenkins, which allows fast updates.

terraform plan would result in:

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # google_pubsub_topic.kubernetes_ci_logs_topic will be created
  + resource "google_pubsub_topic" "kubernetes_ci_logs_topic" {
      + effective_labels = (known after apply)
      + id               = (known after apply)
      + name             = "kubernetes-ci-logs-updates"
      + project          = "k8s-infra-prow"
      + terraform_labels = (known after apply)
    }

  # google_pubsub_topic_iam_binding.publish_binding will be created
  + resource "google_pubsub_topic_iam_binding" "publish_binding" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + members = [
          + "serviceAccount:[email protected]",
        ]
      + project = (known after apply)
      + role    = "roles/pubsub.publisher"
      + topic   = "kubernetes-ci-logs-updates"
    }

  # google_pubsub_topic_iam_binding.read_binding will be created
  + resource "google_pubsub_topic_iam_binding" "read_binding" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + members = [
          + "serviceAccount:[email protected]",
          + "serviceAccount:[email protected]",
          + "serviceAccount:[email protected]",
        ]
      + project = (known after apply)
      + role    = "roles/pubsub.subscriber"
      + topic   = "kubernetes-ci-logs-updates"
    }

  # google_storage_notification.notification will be created
  + resource "google_storage_notification" "notification" {
      + bucket          = "kubernetes-ci-logs"
      + id              = (known after apply)
      + notification_id = (known after apply)
      + payload_format  = "JSON_API_V1"
      + self_link       = (known after apply)
      + topic           = "kubernetes-ci-logs-updates"
    }

Plan: 4 to add, 0 to change, 0 to destroy.

Ref kubernetes/test-infra#33386

This will allow TestGrid and Kettle to subscribe to this topic for
updates, similar to what was done with gs://kubernetes-jenkins, which
allows fast updates.

`terraform plan` would result in:

```
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # google_pubsub_topic.kubernetes_ci_logs_topic will be created
  + resource "google_pubsub_topic" "kubernetes_ci_logs_topic" {
      + effective_labels = (known after apply)
      + id               = (known after apply)
      + name             = "kubernetes-ci-logs-updates"
      + project          = "k8s-infra-prow"
      + terraform_labels = (known after apply)
    }

  # google_pubsub_topic_iam_binding.publish_binding will be created
  + resource "google_pubsub_topic_iam_binding" "publish_binding" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + members = [
          + "serviceAccount:[email protected]",
        ]
      + project = (known after apply)
      + role    = "roles/pubsub.publisher"
      + topic   = "kubernetes-ci-logs-updates"
    }

  # google_pubsub_topic_iam_binding.read_binding will be created
  + resource "google_pubsub_topic_iam_binding" "read_binding" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + members = [
          + "serviceAccount:[email protected]",
          + "serviceAccount:[email protected]",
          + "serviceAccount:[email protected]",
        ]
      + project = (known after apply)
      + role    = "roles/pubsub.subscriber"
      + topic   = "kubernetes-ci-logs-updates"
    }

  # google_storage_notification.notification will be created
  + resource "google_storage_notification" "notification" {
      + bucket          = "kubernetes-ci-logs"
      + id              = (known after apply)
      + notification_id = (known after apply)
      + payload_format  = "JSON_API_V1"
      + self_link       = (known after apply)
      + topic           = "kubernetes-ci-logs-updates"
    }

Plan: 4 to add, 0 to change, 0 to destroy.
```
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 5, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin September 5, 2024 17:28
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2024
@ameukam
Copy link
Member

ameukam commented Sep 5, 2024

/lgtm
/approve
/hold

Remove the hold when ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@michelle192837
Copy link
Contributor Author

Thanks Arnaud!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 288f5b2 into kubernetes:main Sep 5, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 5, 2024
@michelle192837 michelle192837 deleted the notification branch September 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants