-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCS PubSub topic for gs://kubernetes-ci-logs. #7264
Conversation
This will allow TestGrid and Kettle to subscribe to this topic for updates, similar to what was done with gs://kubernetes-jenkins, which allows fast updates. `terraform plan` would result in: ``` Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: + create Terraform will perform the following actions: # google_pubsub_topic.kubernetes_ci_logs_topic will be created + resource "google_pubsub_topic" "kubernetes_ci_logs_topic" { + effective_labels = (known after apply) + id = (known after apply) + name = "kubernetes-ci-logs-updates" + project = "k8s-infra-prow" + terraform_labels = (known after apply) } # google_pubsub_topic_iam_binding.publish_binding will be created + resource "google_pubsub_topic_iam_binding" "publish_binding" { + etag = (known after apply) + id = (known after apply) + members = [ + "serviceAccount:[email protected]", ] + project = (known after apply) + role = "roles/pubsub.publisher" + topic = "kubernetes-ci-logs-updates" } # google_pubsub_topic_iam_binding.read_binding will be created + resource "google_pubsub_topic_iam_binding" "read_binding" { + etag = (known after apply) + id = (known after apply) + members = [ + "serviceAccount:[email protected]", + "serviceAccount:[email protected]", + "serviceAccount:[email protected]", ] + project = (known after apply) + role = "roles/pubsub.subscriber" + topic = "kubernetes-ci-logs-updates" } # google_storage_notification.notification will be created + resource "google_storage_notification" "notification" { + bucket = "kubernetes-ci-logs" + id = (known after apply) + notification_id = (known after apply) + payload_format = "JSON_API_V1" + self_link = (known after apply) + topic = "kubernetes-ci-logs-updates" } Plan: 4 to add, 0 to change, 0 to destroy. ```
/lgtm Remove the hold when ready |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks Arnaud! /hold cancel |
This will allow TestGrid and Kettle to subscribe to this topic for updates, similar to what was done with gs://kubernetes-jenkins, which allows fast updates.
terraform plan
would result in:Ref kubernetes/test-infra#33386