Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regenerate roles #4984

Closed
wants to merge 1 commit into from
Closed

regenerate roles #4984

wants to merge 1 commit into from

Conversation

BenTheElder
Copy link
Member

This PR is just infra/gcp/bash/roles/generate-role-yaml.sh

We probably need to check over the output.

Also not sure how we've actually been applying these.

Doing this before #4983 where I'd actually change the source spec, because regenerating with no changes to the inputs creates this large diff already.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenTheElder
Once this PR has been reviewed and has the lgtm label, please assign spiffxp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/infra Infrastructure management, infrastructure design, code in infra/ size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 18, 2023
@BenTheElder BenTheElder mentioned this pull request Mar 18, 2023
Closed
@BenTheElder
Copy link
Member Author

/hold

probably not the best time to change org roles.

I'd like to see us resolve #4981 soon though.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenTheElder @k8s-ci-robot